[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200416063002.GA299193@kroah.com>
Date: Thu, 16 Apr 2020 08:30:02 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Scott Wood <oss@...error.net>
Cc: Wang Wenhu <wenhu.wang@...o.com>, linux-kernel@...r.kernel.org,
christophe.leroy@....fr, linuxppc-dev@...ts.ozlabs.org,
kernel@...o.com, Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH v2,5/5] drivers: uio: new driver for fsl_85xx_cache_sram
On Wed, Apr 15, 2020 at 02:26:55PM -0500, Scott Wood wrote:
> Instead, have module parameters that take the sizes and alignments you'd like
> to allocate and expose to userspace. Better still would be some sort of
> dynamic allocation (e.g. open a fd, ioctl to set the requested size/alignment,
> if it succeeds you can mmap it, and when the fd is closed the region is
> freed).
No module parameters please, this is not the 1990's.
Use device tree, that is what it is there for.
thanks,
greg k-h
Powered by blists - more mailing lists