linux-kernel - Re: [PATCH -next] drm/omap: venc: remove unused variable 'venc_config_pal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c9e1e60-5ff6-3ee7-e31e-e7cfb0cd279e@ti.com>
Date:   Thu, 16 Apr 2020 09:32:24 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...com>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        YueHaibing <yuehaibing@...wei.com>
CC:     <airlied@...ux.ie>, <daniel@...ll.ch>,
        <sebastian.reichel@...labora.com>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/omap: venc: remove unused variable
 'venc_config_pal_bdghi'

On 15/04/2020 18:39, Laurent Pinchart wrote:
> Hi Yue,
> 
> Thank you for the patch.
> 
> On Wed, Apr 15, 2020 at 09:21:05PM +0800, YueHaibing wrote:
>> drivers/gpu/drm/omapdrm/dss/venc.c:211:33:
>>   warning: 'venc_config_pal_bdghi' defined but not used [-Wunused-const-variable=]
>>   static const struct venc_config venc_config_pal_bdghi = {
>>                                   ^~~~~~~~~~~~~~~~~~~~~
>>
>> It is never used, remove it.
> 
> Tomi, is this the right fix, or should we work on making use of this
> structure ?

I think we can remove it. I'll pick you this patch.

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki