linux-kernel - RE: [PATCH] exfat: remove the assignment of 0 to bool variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Apr 2020 15:34:33 +0900
From:   "Namjae Jeon" <namjae.jeon@...sung.com>
To:     "'Jason Yan'" <yanaijie@...wei.com>
Cc:     <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <sj1557.seo@...sung.com>
Subject: RE: [PATCH] exfat: remove the assignment of 0 to bool variable

> There is no need to init 'sync' in exfat_set_vol_flags().
> This also fixes the following coccicheck warning:
> 
> fs/exfat/super.c:104:6-10: WARNING: Assignment of 0/1 to bool variable
> 
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
Pushed it to exfat dev.

Thanks for your patch!
> ---
>  fs/exfat/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/exfat/super.c b/fs/exfat/super.c index
> 16ed202ef527..b86755468904 100644
> --- a/fs/exfat/super.c
> +++ b/fs/exfat/super.c
> @@ -101,7 +101,7 @@ int exfat_set_vol_flags(struct super_block *sb,
> unsigned short new_flag)  {
>  	struct exfat_sb_info *sbi = EXFAT_SB(sb);
>  	struct pbr64 *bpb;
> -	bool sync = 0;
> +	bool sync;
> 
>  	/* flags are not changed */
>  	if (sbi->vol_flag == new_flag)
> --
> 2.21.1