[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200416065144.GF7901@gondor.apana.org.au>
Date: Thu, 16 Apr 2020 16:51:44 +1000
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Tang Bin <tangbin@...s.chinamobile.com>
Cc: narmstrong@...libre.com, clabbe@...libre.com, davem@...emloft.net,
linux-crypto@...r.kernel.org, linux-amlogic@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6]crypto: amlogic - Delete duplicate dev_err in
meson_crypto_probe()
On Sat, Apr 04, 2020 at 06:07:54AM +0800, Tang Bin wrote:
> When something goes wrong, platform_get_irq() will print an error message,
> so in order to avoid the situation of repeat output,we should remove
> dev_err here.
>
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
> ---
> Changes from v5
> - modify the commit message.
>
> Changes from v4:
> - rewrite the code, because the code in v4 is wrong, sorry.
>
> Changes form v3:
> - fix the theme writing error.
>
> Changes from v2:
> - modify the theme format and content description.
> - reformat the patch, it's the wrong way to resubmit a new patch that
> should be modified on top of the original. The original piece is:
> https://lore.kernel.org/patchwork/patch/1219611/
>
> Changes from v1:
> - the title has changed, because the description is not very detailed.
> - the code has been modified, because it needs to match the theme.
>
> drivers/crypto/amlogic/amlogic-gxl-core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists