linux-kernel - Re: [PATCH V2] crypto: marvell/octeontx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Apr 2020 16:53:39 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     bbrezillon@...nel.org, arno@...isbad.org, schalla@...vell.com,
        davem@...emloft.net, lbartosik@...vell.com,
        colin.king@...onical.com, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH V2] crypto: marvell/octeontx - Add missing '\n' in log
 messages

On Sat, Apr 11, 2020 at 02:06:33PM +0200, Christophe JAILLET wrote:
> Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'.
> 
> While at it, I've introduced a few pr_cont that looked logical to me.
> 
> Fixes: 10b4f09491bf ("crypto: marvell - add the Virtual Function driver for CPT")
> Fixes: d9110b0b01ff ("crypto: marvell - add support for OCTEON TX CPT engine")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> V2: remove a pr_cont after a pr_debug
>     avoid repeating 'engine_group' in a message
> ---
>  .../crypto/marvell/octeontx/otx_cptpf_main.c  |  4 +-
>  .../crypto/marvell/octeontx/otx_cptpf_mbox.c  | 12 +--
>  .../crypto/marvell/octeontx/otx_cptpf_ucode.c | 95 ++++++++++---------
>  .../crypto/marvell/octeontx/otx_cptvf_algs.c  |  6 +-
>  .../crypto/marvell/octeontx/otx_cptvf_main.c  | 12 +--
>  .../marvell/octeontx/otx_cptvf_reqmgr.c       | 10 +-
>  6 files changed, 70 insertions(+), 69 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt