[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d7ed94e7-639e-9c94-6092-e769a2fc6ad1@linaro.org>
Date: Thu, 16 Apr 2020 08:56:39 +0100
From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To: Ajit Pandey <ajitp@...eaurora.org>, alsa-devel@...a-project.org,
broonie@...nel.org, devicetree@...r.kernel.org,
plai@...eaurora.org, bgoswami@...eaurora.org
Cc: linux-kernel@...r.kernel.org, tiwai@...e.com, stephan@...hold.net
Subject: Re: [PATCH 07/11] Documentation: dt-bindings: sound: Add details for
new dai properties
On 11/04/2020 09:02, Ajit Pandey wrote:
> Add changes related to new sub node defining MI2S dai's properties. Such
> properties needs to be configured via board specific dts files.
>
+Adding Stephan Gerlhold
Have a look at https://www.spinics.net/lists/alsa-devel/msg107224.html
patches from Stephan Gerlhold which has better version of specifying sd
line mask and is inline with DSP based solution too.
--srini
> Signed-off-by: Ajit Pandey <ajitp@...eaurora.org>
> ---
> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 33 ++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> index a87a406..727ec03 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> @@ -16,6 +16,8 @@ description: |
> configure Low-Power Audio Interface(LPAIF) core registers across different
> IP versions.
>
> + See also dt-bindings/sound/qcom,lpass.h.
> +
> properties:
> compatible:
> enum:
> @@ -69,6 +71,30 @@ properties:
> '#sound-dai-cells':
> const: 1
>
> + dai-name:
> + - description: Each node represents an MI2S dai and conatins dai specific
> + properties that may change with board layout & dai connections.
> + - type: object
> + - properties:
> + id:
> + - description: dai id among one of value defined in header
> + - type: u32
> + qcom,spkmode-mask:
> + - description: mask defining data lines used for speaker
> + - type: u32
> + qcom,micmode-mask:
> + - description: mask defining data lines used for mic
> + - type: u32
> + qcom,wssrc-mask:
> + - description: mask defining word-select source internal/extrnal on dai
> + - type: u32
> + qcom,loopback-mask:
> + - description: mask defining loopback enable/disable on dai
> + - type: u32
> +
> + required:
> + - id
> +
> required:
> - compatible
> - reg
> @@ -101,3 +127,10 @@ examples:
> #sound-dai-cells = <1>;
> qcom,adsp = <&adsp>;
>
> + prim-mi2s@0 {
> + id = <MI2S_PRIMARY>;
> + qcom,spkmode-mask = <SD1>;
> + qcom,micmode-mask = <SD0>;
> + qcom,wssrc-mask = <INTERNAL>;
> + qcom,loopback-mask = <DISABLE>;
> + };
>
Powered by blists - more mailing lists