linux-kernel - Re: [PATCH] i2c: drivers: Omit superfluous error message inefm32_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9948c5c2-fbdd-4782-8fae-1eccb03e5c85@cmss.chinamobile.com>
Date:   Thu, 16 Apr 2020 09:12:21 +0800
From:   Tang Bin <tangbin@...s.chinamobile.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     wsa@...-dreams.de, o.rempel@...gutronix.de, ardb@...nel.org,
        linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: drivers: Omit superfluous error message
 inefm32_i2c_probe()

Hi Uwe:

On 2020/4/15 22:22, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Apr 15, 2020 at 09:57:34PM +0800, Tang Bin wrote:
>> In the function efm32_i2c_probe(),when get irq failed,the function
>> platform_get_irq() logs an error message,so remove redundant message
>> here.
> adding a space after each comma seems usual style.
Got it, I will notice. Whether should I submit v2 for this problems? Thanks.
>
>> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
>> Signed-off-by: Shengju Zhang <zhangshengju@...s.chinamobile.com>
> Usually the Sign-off of the sender comes last. How is Shengju Zhang
> involved with this patch?
Got it, I will notice next time. Thanks.
>> diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c
>> index a8c6323e7..4de31fae7 100644
>> --- a/drivers/i2c/busses/i2c-efm32.c
>> +++ b/drivers/i2c/busses/i2c-efm32.c
>> @@ -352,7 +352,6 @@ static int efm32_i2c_probe(struct platform_device *pdev)
>>   
>>   	ret = platform_get_irq(pdev, 0);
>>   	if (ret <= 0) {
>> -		dev_err(&pdev->dev, "failed to get irq (%d)\n", ret);
> The change looks fine.

Thanks,

Tang Bin

>