[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1587025984-5696-1-git-send-email-Ashish.Kumar@nxp.com>
Date: Thu, 16 Apr 2020 14:03:04 +0530
From: Ashish Kumar <Ashish.Kumar@....com>
To: broonie@...nel.org, boris.brezillon@...labora.com,
frieder.schrempf@...tron.de
Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
Ashish Kumar <Ashish.Kumar@....com>,
Kuldeep Singh <kuldeep.singh@....com>,
Ashish Kumar <Ashish.kumar@....com>
Subject: [PATCH] spi: spi-fsl-qspi: Reduce devm_ioremap size to 4 times AHB buffer size
Reduce devm_ioremap size to (4 * AHB_BUFER_SIZE) rather than mapping
complete QSPI-Memmory as driver is now independent of flash size.
Flash of any size can be accessed.
Issue was reported on platform where devm_ioremap failure is observed
with size > 256M.
Error log on LS1021ATWR :
fsl-quadspi 1550000.spi: ioremap failed for resource [mem 0x40000000-0x7fffffff]
fsl-quadspi 1550000.spi: Freescale QuadSPI probe failed
fsl-quadspi: probe of 1550000.spi failed with error -12
This change was also suggested previously:
https://patchwork.kernel.org/patch/10508753/#22166385
Signed-off-by: Kuldeep Singh <kuldeep.singh@....com>
Signed-off-by: Ashish Kumar <Ashish.kumar@....com>
---
drivers/spi/spi-fsl-qspi.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-fsl-qspi.c b/drivers/spi/spi-fsl-qspi.c
index 63c9f7e..a41ce81 100644
--- a/drivers/spi/spi-fsl-qspi.c
+++ b/drivers/spi/spi-fsl-qspi.c
@@ -859,14 +859,15 @@ static int fsl_qspi_probe(struct platform_device *pdev)
res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"QuadSPI-memory");
- q->ahb_addr = devm_ioremap_resource(dev, res);
+ q->memmap_phy = res->start;
+ /* Since there are 4 CS max MAP required is 4 time ahb_buf_size */
+ q->ahb_addr = devm_ioremap(dev, q->memmap_phy,
+ (q->devtype_data->ahb_buf_size * 4));
if (IS_ERR(q->ahb_addr)) {
ret = PTR_ERR(q->ahb_addr);
goto err_put_ctrl;
}
- q->memmap_phy = res->start;
-
/* find the clocks */
q->clk_en = devm_clk_get(dev, "qspi_en");
if (IS_ERR(q->clk_en)) {
@@ -939,6 +940,9 @@ static int fsl_qspi_remove(struct platform_device *pdev)
mutex_destroy(&q->lock);
+ if (q->ahb_addr)
+ devm_iounmap(q->dev, q->ahb_addr);
+
return 0;
}
--
2.7.4
Powered by blists - more mailing lists