[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200416085049.GA7193@kozik-lap>
Date: Thu, 16 Apr 2020 10:50:49 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jonathan Bakker <xc-racer2@...e.ca>
Cc: "H. Nikolaus Schaller" <hns@...delico.com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
BenoƮt Cousson <bcousson@...libre.com>,
Tony Lindgren <tony@...mide.com>,
Paul Cercueil <paul@...pouillou.net>,
Ralf Baechle <ralf@...ux-mips.org>,
Paul Burton <paulburton@...nel.org>,
James Hogan <jhogan@...nel.org>, Kukjin Kim <kgene@...nel.org>,
Maxime Ripard <mripard@...nel.org>,
Chen-Yu Tsai <wens@...e.org>,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
Philipp Rossak <embed3d@...il.com>,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
linux-omap@...r.kernel.org, openpvrsgx-devgroup@...ux.org,
letux-kernel@...nphoenux.org, kernel@...a-handheld.com,
linux-mips@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
"linux-samsung-soc@...r.kernel.org"
<linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node
On Wed, Apr 15, 2020 at 11:17:16AM -0700, Jonathan Bakker wrote:
> >>
> >>> +
> >>> + assigned-clocks = <&clocks MOUT_G3D>, <&clocks DOUT_G3D>;
> >>> + assigned-clock-rates = <0>, <66700000>;
> >>> + assigned-clock-parents = <&clocks MOUT_MPLL>;
> >>
> >> Probably this should have status disabled because you do not set
> >> regulator supply.
>
> I don't believe there is a regulator on s5pv210, if there is, then it is a
> fixed regulator with no control on both s5pv210 devices that I have.
>
> The vendor driver did use the regulator framework for its power domain
> implementation, but that definitely shouldn't be upstreamed.
Starting with Exynos4210 usually they have separate regulator from PMIC
but maybe S5Pv210 indeed is different. Leave it then without it.
Best regards,
Krzysztof
Powered by blists - more mailing lists