linux-kernel - Re: [v3 PATCH 5/5] RISC-V: Add EFI stub support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Apr 2020 09:13:42 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Atish Patra <atish.patra@....com>, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Atish Patra <atish.patra@....com>,
        Ard Biesheuvel <ardb@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Catalin Marinas <catalin.marinas@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-efi@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        Masahiro Yamada <masahiroy@...nel.org>
Subject: Re: [v3 PATCH 5/5] RISC-V: Add EFI stub support.

Hi Atish,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on efi/next]
[also build test WARNING on linus/master v5.7-rc1 next-20200415]
[cannot apply to arm/for-next arm64/for-next/core linux/master atish-riscv-linux/topo_v3]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Atish-Patra/Add-UEFI-support-for-RISC-V/20200416-065438
base:   https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
config: riscv-rv32_defconfig (attached as .config)
compiler: riscv32-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/list.h:9,
                    from include/linux/preempt.h:11,
                    from include/linux/spinlock.h:51,
                    from include/linux/seqlock.h:36,
                    from include/linux/time.h:6,
                    from include/linux/efi.h:17,
                    from drivers/firmware/efi/libstub/riscv-stub.c:10:
   drivers/firmware/efi/libstub/riscv-stub.c: In function 'handle_kernel_image':
>> drivers/firmware/efi/libstub/riscv-stub.c:89:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      89 |  if (IS_ALIGNED((u64)_start, MIN_KIMG_ALIGN)) {
         |                 ^
   include/linux/kernel.h:37:30: note: in definition of macro 'IS_ALIGNED'
      37 | #define IS_ALIGNED(x, a)  (((x) & ((typeof(x))(a) - 1)) == 0)
         |                              ^
>> drivers/firmware/efi/libstub/riscv-stub.c:89:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      89 |  if (IS_ALIGNED((u64)_start, MIN_KIMG_ALIGN)) {
         |                 ^
   include/linux/kernel.h:37:44: note: in definition of macro 'IS_ALIGNED'
      37 | #define IS_ALIGNED(x, a)  (((x) & ((typeof(x))(a) - 1)) == 0)
         |                                            ^
   drivers/firmware/efi/libstub/riscv-stub.c:94:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      94 |   *image_addr = (u64)_start;
         |                 ^

vim +89 drivers/firmware/efi/libstub/riscv-stub.c

    69	
    70	efi_status_t handle_kernel_image(unsigned long *image_addr,
    71					 unsigned long *image_size,
    72					 unsigned long *reserve_addr,
    73					 unsigned long *reserve_size,
    74					 unsigned long dram_base,
    75					 efi_loaded_image_t *image)
    76	{
    77		efi_status_t status;
    78		unsigned long kernel_size, kernel_memsize = 0;
    79		unsigned long max_alloc_address;
    80	
    81		if (image->image_base != _start)
    82			pr_efi_err("FIRMWARE BUG: efi_loaded_image_t::image_base has bogus value\n");
    83	
    84		kernel_size = _edata - _start;
    85		kernel_memsize = kernel_size + (_end - _edata);
    86		max_alloc_address = round_up(dram_base, MIN_KIMG_ALIGN) +
    87				    kernel_memsize;
    88	
  > 89		if (IS_ALIGNED((u64)_start, MIN_KIMG_ALIGN)) {

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (19000 bytes)