linux-kernel - [Patch v2] spi: spi-fsl-qspi: Reduce devm_ioremap size to 4 times AHB buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1587034622-16654-1-git-send-email-Ashish.Kumar@nxp.com>
Date:   Thu, 16 Apr 2020 16:27:02 +0530
From:   Ashish Kumar <Ashish.Kumar@....com>
To:     broonie@...nel.org, boris.brezillon@...labora.com,
        frieder.schrempf@...tron.de
Cc:     linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kuldeep Singh <kuldeep.singh@....com>,
        Ashish Kumar <Ashish.kumar@....com>
Subject: [Patch v2] spi: spi-fsl-qspi: Reduce devm_ioremap size to 4 times AHB buffer size

Reduce devm_ioremap size to (4 * AHB_BUFER_SIZE) rather than mapping
complete QSPI-Memmory as driver is now independent of flash size.
Flash of any size can be accessed.

Issue was reported on platform where devm_ioremap failure is observed
with size > 256M.
Error log on LS1021ATWR :
 fsl-quadspi 1550000.spi: ioremap failed for resource [mem 0x40000000-0x7fffffff]
 fsl-quadspi 1550000.spi: Freescale QuadSPI probe failed
 fsl-quadspi: probe of 1550000.spi failed with error -12

This change was also suggested previously:
https://patchwork.kernel.org/patch/10508753/#22166385

Suggested-by: Boris Brezillon <boris.brezillon@...labora.com>
Signed-off-by: Kuldeep Singh <kuldeep.singh@....com>
Signed-off-by: Ashish Kumar <Ashish.kumar@....com>
---
v2:
Add Suggested-by: Boris Brezillon <boris.brezillon@...labora.com>
Incorrporate review comments from Frieder

 drivers/spi/spi-fsl-qspi.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/spi/spi-fsl-qspi.c b/drivers/spi/spi-fsl-qspi.c
index 63c9f7e..5f8aac9 100644
--- a/drivers/spi/spi-fsl-qspi.c
+++ b/drivers/spi/spi-fsl-qspi.c
@@ -859,14 +859,15 @@ static int fsl_qspi_probe(struct platform_device *pdev)
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
 					"QuadSPI-memory");
-	q->ahb_addr = devm_ioremap_resource(dev, res);
+	q->memmap_phy = res->start;
+	/* Since there are 4 CS max MAP required is 4 time ahb_buf_size */
+	q->ahb_addr = devm_ioremap(dev, q->memmap_phy,
+				   (q->devtype_data->ahb_buf_size * 4));
 	if (IS_ERR(q->ahb_addr)) {
 		ret = PTR_ERR(q->ahb_addr);
 		goto err_put_ctrl;
 	}
 
-	q->memmap_phy = res->start;
-
 	/* find the clocks */
 	q->clk_en = devm_clk_get(dev, "qspi_en");
 	if (IS_ERR(q->clk_en)) {
-- 
2.7.4