linux-kernel - Re: [PATCH v3 00/12] Rework READ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <809e006e-6641-c252-53a1-cc4479d2ca89@de.ibm.com>
Date:   Thu, 16 Apr 2020 14:30:36 +0200
From:   Christian Borntraeger <borntraeger@...ibm.com>
To:     Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org
Cc:     linux-arch@...r.kernel.org, kernel-team@...roid.com,
        Michael Ellerman <mpe@...erman.id.au>,
        Peter Zijlstra <peterz@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Segher Boessenkool <segher@...nel.crashing.org>,
        Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH v3 00/12] Rework READ_ONCE() to improve codegen


On 15.04.20 18:52, Will Deacon wrote:
> Hi everyone,
> 
> This is version three of the patches I previously posted for improving
> the code generation of READ_ONCE() and moving the minimum GCC version
> to 4.8:
> 
> RFC: https://lore.kernel.org/lkml/20200110165636.28035-1-will@kernel.org
> v2:  https://lore.kernel.org/lkml/20200123153341.19947-1-will@kernel.org
> 
> Although v2 was queued up by Peter in -tip, it was found to break the
> build for m68k and sparc32. We fixed m68k during the merge window and
> I've since posted patches to fix sparc32 here:
> 
>   https://lore.kernel.org/lkml/20200414214011.2699-1-will@kernel.org
> 
> This series is a refresh on top of 5.7-rc1, the main changes being:
> 
>   * Fix another issue where 'const' is assigned to non-const via
>     WRITE_ONCE(), this time in the tls code
> 
>   * Fix READ_ONCE_NOCHECK() abuse in arm64 checksum code
> 
>   * Added Reviewed-bys and Acks from v2
> 
> Hopefully this can be considered for 5.8, along with the sparc32 changes.
> 
> Cheers,
> 
> Will
> 
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Segher Boessenkool <segher@...nel.crashing.org>
> Cc: Christian Borntraeger <borntraeger@...ibm.com>
> Cc: Luc Van Oostenryck <luc.vanoostenryck@...il.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Peter Oberparleiter <oberpar@...ux.ibm.com>
> Cc: Masahiro Yamada <masahiroy@...nel.org>
> Cc: Nick Desaulniers <ndesaulniers@...gle.com>
> 

I gave this series a try and s390 seems to compile fine and it also seems to
properly compile the the ipte_unlock_siif function in arch/s390/kvm/gaccess.c
This function was miscompiled with gcc4.6 and the trigger for replacing
ACCESS_ONCE with READ_ONCE