[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7d17eaf8-a3a8-eaba-ff80-e857135571e1@arista.com>
Date: Fri, 17 Apr 2020 23:59:00 +0100
From: Dmitry Safonov <dima@...sta.com>
To: Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org
Cc: Dmitry Safonov <0x7f454c46@...il.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Ingo Molnar <mingo@...nel.org>, Jiri Slaby <jslaby@...e.com>,
Petr Mladek <pmladek@...e.com>,
Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
Steven Rostedt <rostedt@...dmis.org>,
Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
Albert Ou <aou@...s.berkeley.edu>,
Ben Segall <bsegall@...gle.com>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Greentime Hu <green.hu@...il.com>,
Ingo Molnar <mingo@...hat.com>,
James Hogan <jhogan@...nel.org>,
Juri Lelli <juri.lelli@...hat.com>,
Mel Gorman <mgorman@...e.de>, Michal Simek <monstr@...str.eu>,
Palmer Dabbelt <palmer@...belt.com>,
Paul Burton <paulburton@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>,
Peter Zijlstra <peterz@...radead.org>,
Ralf Baechle <ralf@...ux-mips.org>,
Thomas Gleixner <tglx@...utronix.de>,
Vincent Chen <deanbo422@...il.com>,
Vincent Guittot <vincent.guittot@...aro.org>,
Will Deacon <will@...nel.org>, linux-mips@...r.kernel.org,
linux-riscv@...ts.infradead.org
Subject: Re: [PATCHv2 01/50] kallsyms/printk: Add loglvl to print_ip_sym()
Hi Joe,
On 3/16/20 3:29 PM, Joe Perches wrote:
> On Mon, 2020-03-16 at 14:38 +0000, Dmitry Safonov wrote:
>> print_ip_sym() needs to have a log level parameter to comply with other
>> parts being printed. Otherwise, half of the expected backtrace would be
>> printed and other may be missing with some logging level.
>
> There are 15 instances of print_ip_sym.
>
> Perhaps it'd be better to get rid of print_ip_sym
> altogether by expanding it in-place instead.
I tried this and format-string + two casts to (void *) take some space
and the resulting printk() doesn't fit 80 cols.
I guess, it's minor and it can be done on the top of v3..
>
>> arch/microblaze/kernel/unwind.c | 2 +-
>> arch/mips/kernel/traps.c | 4 ++--
>> arch/nds32/kernel/traps.c | 4 ++--
>> arch/riscv/kernel/stacktrace.c | 2 +-
>> include/linux/kallsyms.h | 4 ++--
>> kernel/locking/lockdep.c | 4 ++--
>> kernel/sched/core.c | 6 ++----
>> kernel/trace/ftrace.c | 8 ++++----
>> tools/include/linux/kallsyms.h | 2 +-
>
>
Thanks,
Dmitry
Powered by blists - more mailing lists