[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200417090115.3cccc9bd@coco.lan>
Date: Fri, 17 Apr 2020 09:01:15 +0200
From: Mauro Carvalho Chehab <mchehab@...nel.org>
To: Ezequiel Garcia <ezequiel@...labora.com>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>,
Linux Next Mailing List <linux-next@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-media@...r.kernel.org, Hans Verkuil <hverkuil@...all.nl>
Subject: Re: linux-next: build warning after merge of the v4l-dvb tree
Em Fri, 17 Apr 2020 02:13:47 -0300
Ezequiel Garcia <ezequiel@...labora.com> escreveu:
> Hi Stephen,
>
> On Fri, 2020-04-17 at 10:22 +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the v4l-dvb tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > WARNING: unmet direct dependencies detected for MEDIA_CONTROLLER_REQUEST_API
> > Depends on [n]: MEDIA_SUPPORT [=m] && MEDIA_CONTROLLER [=y] && STAGING_MEDIA [=n]
> > Selected by [m]:
> > - VIDEO_VIVID [=m] && MEDIA_SUPPORT [=m] && MEDIA_TEST_SUPPORT [=y] && V4L_TEST_DRIVERS [=y] && VIDEO_DEV [=m] && VIDEO_V4L2 [=m] && !SPARC32 &&
> > !SPARC64 && FB [=y] && HAS_DMA [=y]
> >
>
> Ugh, my bad. MEDIA_CONTROLLER_REQUEST_API can't
> depend on staging, after this recently merged commit:
>
> "media: Kconfig: Don't expose the Request API option"
>
> So, we should fix that with:
>
> diff --git a/drivers/media/mc/Kconfig b/drivers/media/mc/Kconfig
> index 7c9628f37196..4815b9dde9af 100644
> --- a/drivers/media/mc/Kconfig
> +++ b/drivers/media/mc/Kconfig
> @@ -14,7 +14,7 @@ config MEDIA_CONTROLLER_DVB
>
> config MEDIA_CONTROLLER_REQUEST_API
> bool
> - depends on MEDIA_CONTROLLER && STAGING_MEDIA
> + depends on MEDIA_CONTROLLER
> help
> DO NOT ENABLE THIS OPTION UNLESS YOU KNOW WHAT YOU'RE DOING.
>
> Mauro what do you think?
Dropped the dependency and applied on media.
I also addressed the "select PCI" issue, with causes troubles on
s390 random configs (due to HAS_PCI=n on s390).
Thanks,
Mauro
Powered by blists - more mailing lists