linux-kernel - [PATCH] locking/static_keys: make old_true_key and old_false

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200417073945.45851-1-yanaijie@huawei.com>
Date:   Fri, 17 Apr 2020 15:39:45 +0800
From:   Jason Yan <yanaijie@...wei.com>
To:     <tglx@...utronix.de>, <linux-kernel@...r.kernel.org>
CC:     Jason Yan <yanaijie@...wei.com>, Hulk Robot <hulkci@...wei.com>
Subject: [PATCH] locking/static_keys: make old_true_key and old_false_key static

Fix the following sparse warning:

lib/test_static_keys.c:15:19: warning: symbol 'old_true_key' was not
declared. Should it be static?
lib/test_static_keys.c:16:19: warning: symbol 'old_false_key' was not
declared. Should it be static?

Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Jason Yan <yanaijie@...wei.com>
---
 lib/test_static_keys.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/test_static_keys.c b/lib/test_static_keys.c
index 42daa74be029..41658c5bf770 100644
--- a/lib/test_static_keys.c
+++ b/lib/test_static_keys.c
@@ -12,8 +12,8 @@
 #include <linux/jump_label.h>
 
 /* old keys */
-struct static_key old_true_key	= STATIC_KEY_INIT_TRUE;
-struct static_key old_false_key	= STATIC_KEY_INIT_FALSE;
+static struct static_key old_true_key	= STATIC_KEY_INIT_TRUE;
+static struct static_key old_false_key	= STATIC_KEY_INIT_FALSE;
 
 /* new api */
 DEFINE_STATIC_KEY_TRUE(true_key);
-- 
2.21.1