linux-kernel - Re: [PATCH] samples/hw_breakpoint: make sample

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200417073155.GA10812@willie-the-truck>
Date:   Fri, 17 Apr 2020 08:31:55 +0100
From:   Will Deacon <will@...nel.org>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] samples/hw_breakpoint: make sample_hbp static

On Fri, Apr 17, 2020 at 03:35:42PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
> 
> samples/hw_breakpoint/data_breakpoint.c:24:19: warning: symbol
> 'sample_hbp' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>  samples/hw_breakpoint/data_breakpoint.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/samples/hw_breakpoint/data_breakpoint.c b/samples/hw_breakpoint/data_breakpoint.c
> index 418c46fe5ffc..37c4f0ea8e53 100644
> --- a/samples/hw_breakpoint/data_breakpoint.c
> +++ b/samples/hw_breakpoint/data_breakpoint.c
> @@ -21,7 +21,7 @@
>  #include <linux/perf_event.h>
>  #include <linux/hw_breakpoint.h>
>  
> -struct perf_event * __percpu *sample_hbp;
> +static struct perf_event * __percpu *sample_hbp;
>  
>  static char ksym_name[KSYM_NAME_LEN] = "jiffies";
>  module_param_string(ksym, ksym_name, KSYM_NAME_LEN, S_IRUGO);

Acked-by: Will Deacon <will@...nel.org>

Will