linux-kernel - Re: [PATCH V3 1/5] dt-bindings: clock: Convert i.MX6Q clock to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200417074742.geo3hvvencztb3xv@pengutronix.de>
Date:   Fri, 17 Apr 2020 09:47:42 +0200
From:   Marco Felsch <m.felsch@...gutronix.de>
To:     Anson Huang <Anson.Huang@....com>
Cc:     mturquette@...libre.com, sboyd@...nel.org, robh+dt@...nel.org,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Linux-imx@....com
Subject: Re: [PATCH V3 1/5] dt-bindings: clock: Convert i.MX6Q clock to
 json-schema

Hi Anson,

thanks for the patches :) one last nitpick.

On 20-04-17 08:41, Anson Huang wrote:

...

> +examples:
> +  # Clock Control Module node:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    clks: clock-controller@...4000 {
> +        compatible = "fsl,imx6q-ccm";
> +        reg = <0x020c4000 0x4000>;
> +        interrupts = <0 87 IRQ_TYPE_LEVEL_HIGH>,
> +                     <0 88 IRQ_TYPE_LEVEL_HIGH>;

The imx6ull and others start using the GIC_SPI define within the
example. We should take the chance to uniform that. Apart of this feel
free to add my:

Reviewed-by: Marco Felsch <m.felsch@...gutronix.de>

Regards,
  Marco

> +        #clock-cells = <1>;
> +    };