linux-kernel - Re: [PATCH] zram: fix writeback_store returning zero in most situations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKuMfTX3PW8FgpGyp1g=CZm4yC6pQ_MK4LFmBoin2zCTqDF0xQ@mail.gmail.com>
Date:   Thu, 16 Apr 2020 17:52:31 -0700
From:   Justin Gottula <justin@...ttula.com>
To:     Minchan Kim <minchan@...nel.org>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Nitin Gupta <ngupta@...are.org>, Jens Axboe <axboe@...nel.dk>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] zram: fix writeback_store returning zero in most situations

On Thu, Apr 16, 2020 at 5:45 PM Justin Gottula <justin@...ttula.com> wrote:
>
> 2. There is a bit of a predicament with the keep-going-even-if-an-error-
> happened approach. [...]

Oops. I meant to also include this in my reply:

I suppose a reasonable way to address #2 might be to condense any error(s)
arising from submit_bio_wait into one writeback_store error return value
whose purpose is to indicate that the backing device itself had some sort
of write problem(s).