lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Apr 2020 10:08:26 +0200 From: Arnd Bergmann <arnd@...db.de> To: Saeed Mahameed <saeedm@...lanox.com> Cc: Masahiro Yamada <masahiroy@...nel.org>, Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>, Jason Gunthorpe <jgg@...pe.ca>, Nicolas Pitre <nico@...xnic.net>, Jani Nikula <jani.nikula@...ux.intel.com>, Neil Armstrong <narmstrong@...libre.com>, Laurent Pinchart <Laurent.pinchart@...asonboard.com>, Leon Romanovsky <leon@...nel.org>, Kieran Bingham <kieran.bingham+renesas@...asonboard.com>, Jonas Karlman <jonas@...boo.se>, David Airlie <airlied@...ux.ie>, Jernej Skrabec <jernej.skrabec@...l.net>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Networking <netdev@...r.kernel.org>, linux-rdma <linux-rdma@...r.kernel.org> Subject: Re: [RFC PATCH 2/2] net/mlx5: Kconfig: Use "uses" instead of "imply" On Fri, Apr 17, 2020 at 3:12 AM Saeed Mahameed <saeedm@...lanox.com> wrote: > @@ -7,10 +7,10 @@ config MLX5_CORE > tristate "Mellanox 5th generation network adapters (ConnectX series) core driver" > depends on PCI > select NET_DEVLINK > - imply PTP_1588_CLOCK > - imply VXLAN > - imply MLXFW > - imply PCI_HYPERV_INTERFACE > + uses PTP_1588_CLOCK > + uses VXLAN > + uses MLXFW > + uses PCI_HYPERV_INTERFACE I have confirmed in the meantime that changing the PCI_HYPERV_INTERFACE dependency is indeed required, in addition to PTP_1588_CLOCK and VXLAN that the randconfig tests found earlier: x86_64-linux-ld: drivers/net/ethernet/mellanox/mlx5/core/main.o: in function `mlx5_unload': main.c:(.text+0x325): undefined reference to `mlx5_hv_vhca_cleanup' I also checked that there is no link failure with MLX5_CORE=y and MLXFW=m, but only because of an IS_REACHABLE() check in mlxfw/mlxfw.h. I suppose that should be changed back to IS_ENABLED() now along with the Kconfig check. Arnd
Powered by blists - more mailing lists