linux-kernel - Re: [PATCH wireless-drivers v3] iwlwifi: actually check allocated conf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pnc6pmiw.fsf@kamboji.qca.qualcomm.com>
Date:   Fri, 17 Apr 2020 11:03:03 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Sedat Dilek <sedat.dilek@...il.com>
Cc:     Johannes Berg <johannes.berg@...el.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Luca Coelho <luciano.coelho@...el.com>,
        Intel Linux Wireless <linuxwifi@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Chris Rorvick <chris@...vick.com>
Subject: Re: [PATCH wireless-drivers v3] iwlwifi: actually check allocated conf_tlv pointer

Sedat Dilek <sedat.dilek@...il.com> writes:

> From: Chris Rorvick <chris@...vick.com>
>
> Commit 71bc0334a637 ("iwlwifi: check allocated pointer when allocating
> conf_tlvs") attempted to fix a typoe introduced by commit 17b809c9b22e
> ("iwlwifi: dbg: move debug data to a struct") but does not implement the
> check correctly.
>
> Fixes: 71bc0334a637 ("iwlwifi: check allocated pointer when allocating conf_tlvs")
> Tweeted-by: @grsecurity
> Message-Id: <20200402050219.4842-1-chris@...vick.com>
> Signed-off-by: Chris Rorvick <chris@...vick.com>
> Signed-off-by: Sedat Dilek <sedat.dilek@...il.com>

Thanks, looks good to me. I'll just remove the Message-Id tag, it's not
really needed in this case.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches