linux-kernel - Re: [PATCH] mtd: spi-nor: add cmdlineparts to intel-spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200417090759.GN2586@lahna.fi.intel.com>
Date:   Fri, 17 Apr 2020 12:07:59 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     "Ronald G. Minnich" <rminnich@...il.com>
Cc:     "Ronald G. Minnich" <rminnich@...gle.com>,
        Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Boris Brezillon <bbrezillon@...nel.org>,
        Jethro Beekman <jethro@...tanix.com>,
        Enrico Weigelt <info@...ux.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: add cmdlineparts to intel-spi

On Thu, Apr 16, 2020 at 09:28:28AM -0700, Ronald G. Minnich wrote:
> On Intel platforms, the usable SPI area is located several
> MiB in from the start, to leave room for descriptors and
> the Management Engine binary. Further, not all the remaining
> space can be used, as the last 16 MiB contains firmware.
> 
> To make the SPI usable for mtdblock and other devices,
> it is necessary to enable command line partitions so the
> middle usable region can be specified.
> 
> Add a part_probes array which includes only "cmdelineparts",
> and change to mtd_device_parse_register to use this part_probes.
> 
> Signed-off-by: Ronald G. Minnich <rminnich@...gle.com>

I guess the $subject should be something like:

  mtd: spi-nor: controllers: intel-spi: Add support for command line partitions

The patch itself looks good to me,

Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>