linux-kernel - Re: [PATCH] x86/asm: Provide a Kconfig symbol for disabling old assembly annotations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8fe6e63a-fd92-aec7-26ae-da65711b5747@suse.cz>
Date:   Fri, 17 Apr 2020 12:08:44 +0200
From:   Jiri Slaby <jslaby@...e.cz>
To:     Mark Brown <broonie@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>
Cc:     x86@...nel.org, Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/asm: Provide a Kconfig symbol for disabling old
 assembly annotations

On 16. 04. 20, 20:24, Mark Brown wrote:
> As x86 was converted to use the modern SYM_ annotations for assembly ifdefs
> were added to remove the generic definitions of the old style annotations
> on x86. Rather than collect a list of architectures in the ifdefs as more
> architectures are converted over provide a Kconfig symbol for this and
> update x86 to use it.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>

Acked-by: Jiri Slaby <jslaby@...e.cz>

> ---
> 
> arm64 will all being well be able to use this shortly.
> 
>  arch/x86/Kconfig        | 1 +
>  include/linux/linkage.h | 8 ++++----
>  lib/Kconfig             | 3 +++
>  3 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 5706d0c8377f..1c6f88cefc88 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -92,6 +92,7 @@ config X86
>  	select ARCH_USE_BUILTIN_BSWAP
>  	select ARCH_USE_QUEUED_RWLOCKS
>  	select ARCH_USE_QUEUED_SPINLOCKS
> +	select ARCH_USE_SYM_ANNOTATIONS
>  	select ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH
>  	select ARCH_WANT_DEFAULT_BPF_JIT	if X86_64
>  	select ARCH_WANTS_DYNAMIC_TASK_STRUCT
...
thanks,
-- 
js
suse labs