[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ecb3e3e1-7761-faa7-10fa-67da69604306@cogentembedded.com>
Date: Fri, 17 Apr 2020 13:26:43 +0300
From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To: Jason Yan <yanaijie@...wei.com>, f.fainelli@...il.com,
tglx@...utronix.de, jason@...edaemon.net, maz@...nel.org,
justinpopo6@...il.com, bcm-kernel-feedback-list@...adcom.com,
linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static
Hello!
On 17.04.2020 10:40, Jason Yan wrote:
> Fix the following sparse warning:
>
> drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
> 'bcm7038_l1_of_init' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
> drivers/irqchip/irq-bcm7038-l1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c
> index eb9bce93cd05..fd7c537fb42a 100644
> --- a/drivers/irqchip/irq-bcm7038-l1.c
> +++ b/drivers/irqchip/irq-bcm7038-l1.c
> @@ -416,7 +416,7 @@ static const struct irq_domain_ops bcm7038_l1_domain_ops = {
> .map = bcm7038_l1_map,
> };
>
> -int __init bcm7038_l1_of_init(struct device_node *dn,
> +static int __init bcm7038_l1_of_init(struct device_node *dn,
> struct device_node *parent)
Reindent the above line please, it should start under *struct* on the 1st
line.
[...]
MBR, Sergei
Powered by blists - more mailing lists