linux-kernel - Re: [PATCH] dts: arm: stih418: Fix complain about IRQ_TYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <348e46ed-c0f6-ffb8-f8e0-0aa6e7e207f9@st.com>
Date:   Fri, 17 Apr 2020 10:45:07 +0000
From:   Patrice CHOTARD <patrice.chotard@...com>
To:     Alain Volmat <avolmat@...com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dts: arm: stih418: Fix complain about IRQ_TYPE_NONE usage

Hi Alain

On 3/22/20 5:16 PM, Alain Volmat wrote:
> Since commit 83a86fbb5b56 ("irqchip/gic: Loudly complain about the use of IRQ_TYPE_NONE")
> kernel is complaining about the IRQ_TYPE_NONE usage which shouldn't
> be used.
>
> Use IRQ_TYPE_LEVEL_HIGH instead.
>
> Signed-off-by: Alain Volmat <avolmat@...com>
> ---
>  arch/arm/boot/dts/stih418.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stih418.dtsi b/arch/arm/boot/dts/stih418.dtsi
> index 83411322bd92..a05e2278b448 100644
> --- a/arch/arm/boot/dts/stih418.dtsi
> +++ b/arch/arm/boot/dts/stih418.dtsi
> @@ -50,7 +50,7 @@
>  		ohci0: usb@...3c00 {
>  			compatible = "st,st-ohci-300x";
>  			reg = <0x9a03c00 0x100>;
> -			interrupts = <GIC_SPI 180 IRQ_TYPE_NONE>;
> +			interrupts = <GIC_SPI 180 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>;
>  			resets = <&powerdown STIH407_USB2_PORT0_POWERDOWN>,
>  				 <&softreset STIH407_USB2_PORT0_SOFTRESET>;
> @@ -62,7 +62,7 @@
>  		ehci0: usb@...3e00 {
>  			compatible = "st,st-ehci-300x";
>  			reg = <0x9a03e00 0x100>;
> -			interrupts = <GIC_SPI 151 IRQ_TYPE_NONE>;
> +			interrupts = <GIC_SPI 151 IRQ_TYPE_LEVEL_HIGH>;
>  			pinctrl-names = "default";
>  			pinctrl-0 = <&pinctrl_usb0>;
>  			clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>;
> @@ -76,7 +76,7 @@
>  		ohci1: usb@...3c00 {
>  			compatible = "st,st-ohci-300x";
>  			reg = <0x9a83c00 0x100>;
> -			interrupts = <GIC_SPI 181 IRQ_TYPE_NONE>;
> +			interrupts = <GIC_SPI 181 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>;
>  			resets = <&powerdown STIH407_USB2_PORT1_POWERDOWN>,
>  				 <&softreset STIH407_USB2_PORT1_SOFTRESET>;
> @@ -88,7 +88,7 @@
>  		ehci1: usb@...3e00 {
>  			compatible = "st,st-ehci-300x";
>  			reg = <0x9a83e00 0x100>;
> -			interrupts = <GIC_SPI 153 IRQ_TYPE_NONE>;
> +			interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>;
>  			pinctrl-names = "default";
>  			pinctrl-0 = <&pinctrl_usb1>;
>  			clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>;

Applied on sti-dt-for-v5.8-round1

Thanks

Patrice