linux-kernel - Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a71e75e8e391c76bf2f260abbaad4f9d@kernel.org>
Date:   Fri, 17 Apr 2020 12:07:21 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        f.fainelli@...il.com, tglx@...utronix.de, jason@...edaemon.net,
        justinpopo6@...il.com, bcm-kernel-feedback-list@...adcom.com,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static

On 2020-04-17 11:56, Jason Yan wrote:
> 在 2020/4/17 18:26, Sergei Shtylyov 写道:
>> Hello!
>> 
>> On 17.04.2020 10:40, Jason Yan wrote:
>> 
>>> Fix the following sparse warning:
>>> 
>>> drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
>>> 'bcm7038_l1_of_init' was not declared. Should it be static?
>>> 
>>> Reported-by: Hulk Robot <hulkci@...wei.com>
>>> Signed-off-by: Jason Yan <yanaijie@...wei.com>
>>> ---
>>>   drivers/irqchip/irq-bcm7038-l1.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/drivers/irqchip/irq-bcm7038-l1.c 
>>> b/drivers/irqchip/irq-bcm7038-l1.c
>>> index eb9bce93cd05..fd7c537fb42a 100644
>>> --- a/drivers/irqchip/irq-bcm7038-l1.c
>>> +++ b/drivers/irqchip/irq-bcm7038-l1.c
>>> @@ -416,7 +416,7 @@ static const struct irq_domain_ops 
>>> bcm7038_l1_domain_ops = {
>>>       .map            = bcm7038_l1_map,
>>>   };
>>> -int __init bcm7038_l1_of_init(struct device_node *dn,
>>> +static int __init bcm7038_l1_of_init(struct device_node *dn,
>>>                     struct device_node *parent)
>> 
>>     Reindent the above line please, it should start under *struct* on 
>> the 1st line.
> 
> OK, will cook a new one.

Please don't bother. I've picked the patch already, and it is on its way 
to Linus.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...