linux-kernel - Re: [PATCH v2] dmaengine: dw-edma: Decouple dw-edma-core.c from struct pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200417115030.GM72691@vkoul-mobl>
Date:   Fri, 17 Apr 2020 17:20:30 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Alan Mikhak <alan.mikhak@...ive.com>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org, gustavo.pimentel@...opsys.com,
        dan.j.williams@...el.com, kishon@...com, paul.walmsley@...ive.com
Subject: Re: [PATCH v2] dmaengine: dw-edma: Decouple dw-edma-core.c from
 struct pci_dev

On 15-04-20, 10:27, Alan Mikhak wrote:
> From: Alan Mikhak <alan.mikhak@...ive.com>
> 
> Decouple dw-edma-core.c from struct pci_dev as a step toward integration
> of dw-edma with pci-epf-test so the latter can initiate dma operations
> locally from the endpoint side. A barrier to such integration is the
> dependency of dw_edma_probe() and other functions in dw-edma-core.c on
> struct pci_dev.
> 
> The Synopsys DesignWare dw-edma driver was designed to run on host side
> of PCIe link to initiate DMA operations remotely using eDMA channels of
> PCIe controller on the endpoint side. This can be inferred from seeing
> that dw-edma uses struct pci_dev and accesses hardware registers of dma
> channels across the bus using BAR0 and BAR2.
> 
> The ops field of struct dw_edma in dw-edma-core.h is currenty undefined:
> 
> const struct dw_edma_core_ops   *ops;
> 
> However, the kernel builds without failure even when dw-edma driver is
> enabled. Instead of removing the currently undefined and usued ops field,
> define struct dw_edma_core_ops and use the ops field to decouple
> dw-edma-core.c from struct pci_dev.

Applied, thanks

-- 
~Vinod