linux-kernel - Re: [PATCH -next] platform/x86: wmi: Make two functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vdh7O6PjogbJzTU317mhXV6yfzSGtM1F==WxnTxDccSQQ@mail.gmail.com>
Date:   Fri, 17 Apr 2020 16:40:09 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Mattias Jacobsson <2pi@....nu>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] platform/x86: wmi: Make two functions static

On Thu, Apr 2, 2020 at 10:16 AM YueHaibing <yuehaibing@...wei.com> wrote:
>
> Fix sparse warnings:
>
> drivers/platform/x86/xiaomi-wmi.c:26:5: warning: symbol 'xiaomi_wmi_probe' was not declared. Should it be static?
> drivers/platform/x86/xiaomi-wmi.c:51:6: warning: symbol 'xiaomi_wmi_notify' was not declared. Should it be static?
>

Pushed to my review and testing queue, thanks!

> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/platform/x86/xiaomi-wmi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/xiaomi-wmi.c b/drivers/platform/x86/xiaomi-wmi.c
> index 601cbb282f54..54a2546bb93b 100644
> --- a/drivers/platform/x86/xiaomi-wmi.c
> +++ b/drivers/platform/x86/xiaomi-wmi.c
> @@ -23,7 +23,7 @@ struct xiaomi_wmi {
>         unsigned int key_code;
>  };
>
> -int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)
> +static int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)
>  {
>         struct xiaomi_wmi *data;
>
> @@ -48,7 +48,7 @@ int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)
>         return input_register_device(data->input_dev);
>  }
>
> -void xiaomi_wmi_notify(struct wmi_device *wdev, union acpi_object *dummy)
> +static void xiaomi_wmi_notify(struct wmi_device *wdev, union acpi_object *dummy)
>  {
>         struct xiaomi_wmi *data;
>
> --
> 2.17.1
>
>


-- 
With Best Regards,
Andy Shevchenko