[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VdQ58A39HYnW-7CYJgp4+adrzcoiQ4KmTq=0snVAokH9g@mail.gmail.com>
Date: Fri, 17 Apr 2020 16:45:05 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
Hartmut Knaack <knaack.h@....de>,
Lars-Peter Clausen <lars@...afoo.de>,
Peter Meerwald-Stadler <pmeerw@...erw.net>,
Gregory CLEMENT <gregory.clement@...tlin.com>,
linux-iio <linux-iio@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] iio: adc: ti-ads8344: properly byte swap value
On Thu, Apr 16, 2020 at 11:55 PM Alexandre Belloni
<alexandre.belloni@...tlin.com> wrote:
>
> The first received byte is the MSB, followed by the LSB so the value needs
> to be byte swapped.
>
> Also, the ADC actually has a delay of one clock on the SPI bus. Read three
> bytes to get the last bit.
> + return adc->rx_buf[0] << 9 | adc->rx_buf[1] << 1 | adc->rx_buf[2] >> 7;
I just realize, isn't it an open coded variant of ror() / rol()?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists