linux-kernel - Re: [PATCH v10 3/6] iio: adc: mp2629: Add support for mp2629 ADC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b4c7de2-aa85-65aa-be5e-3daed689c44d@gmail.com>
Date:   Fri, 17 Apr 2020 16:51:52 +0200
From:   saravanan sekar <sravanhome@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>, lee.jones@...aro.org,
        andy.shevchenko@...il.com, robh+dt@...nel.org, jic23@...nel.org,
        knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net, sre@...nel.org
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v10 3/6] iio: adc: mp2629: Add support for mp2629 ADC
 driver

Hi Randy,

On 17/04/20 4:35 pm, Randy Dunlap wrote:
> Hi--
>
> On 4/17/20 1:50 AM, Saravanan Sekar wrote:
>> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
>> index 82e33082958c..ef0c0cd31855 100644
>> --- a/drivers/iio/adc/Kconfig
>> +++ b/drivers/iio/adc/Kconfig
>> @@ -680,6 +680,16 @@ config MESON_SARADC
>>   	  To compile this driver as a module, choose M here: the
>>   	  module will be called meson_saradc.
>>   
>> +config MP2629_ADC
>> +	tristate "Monolithic MP2629 ADC driver"
>> +	depends on MFD_MP2629
> 	depends on I2C
> ?

Made "depends on I2C" in MFD_MP2629, hope not needed becomes redundant here

Thanks,
Saravanan

>> +	help
>> +	  Say yes to have support for battery charger IC MP2629 ADC device
>> +	  accessed over I2C.
>> +
>> +	  This driver provides ADC conversion of system, input power supply
>> +	  and battery voltage & current information.
>> +
>>   config NAU7802
>>   	tristate "Nuvoton NAU7802 ADC driver"
>>   	depends on I2C
> thanks.