linux-kernel - Re: [PATCH -next] drm/gma500: remove unused variable 'hdmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200417152414.GR3456981@phenom.ffwll.local>
Date:   Fri, 17 Apr 2020 17:24:14 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     patrik.r.jakobsson@...il.com, airlied@...ux.ie, daniel@...ll.ch,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drm/gma500: remove unused variable 'hdmi_ids'

On Fri, Apr 17, 2020 at 06:10:32PM +0800, YueHaibing wrote:
> drivers/gpu/drm/gma500/oaktrail_hdmi.c:676:35: warning: ‘hdmi_ids’ defined but not used [-Wunused-const-variable=]
>  static const struct pci_device_id hdmi_ids[] = {
>                                    ^~~~~~~~
> 
> It is never used, remove it.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Queued for 5.8, thanks for your patch.
-Daniel

> ---
>  drivers/gpu/drm/gma500/oaktrail_hdmi.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi.c b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> index b25086f252ae..a097a59a9eae 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> @@ -663,11 +663,6 @@ void oaktrail_hdmi_init(struct drm_device *dev,
>  	kfree(gma_encoder);
>  }
>  
> -static const struct pci_device_id hdmi_ids[] = {
> -	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x080d) },
> -	{ 0 }
> -};
> -
>  void oaktrail_hdmi_setup(struct drm_device *dev)
>  {
>  	struct drm_psb_private *dev_priv = dev->dev_private;
> -- 
> 2.17.1
> 
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch