linux-kernel - Re: [PATCH 5.6 000/254] 5.6.5-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 17 Apr 2020 11:05:22 -0600
From:   shuah <shuah@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        torvalds@...ux-foundation.org
Cc:     linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
        linux@...ck-us.net, patches@...nelci.org,
        ben.hutchings@...ethink.co.uk, lkft-triage@...ts.linaro.org,
        stable@...r.kernel.org, shuah <shuah@...nel.org>
Subject: Re: [PATCH 5.6 000/254] 5.6.5-rc1 review

On 4/17/20 2:38 AM, Greg Kroah-Hartman wrote:
> On Thu, Apr 16, 2020 at 03:35:35PM -0600, shuah wrote:
>> On 4/16/20 7:21 AM, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 5.6.5 release.
>>> There are 254 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Sat, 18 Apr 2020 13:11:20 +0000.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>> 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.6.5-rc1.gz
>>> or in the git tree and branch at:
>>> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.6.y
>>> and the diffstat can be found below.
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>
>> Compiled and booted on my test system. No dmesg regressions.
>> reboot and poweroff hang forever. I saw this problem on
>> Linux 5.7rc1 as well.
>>
>> AMD Ryzen 5 PRO 2400GE
>>
>> I don't see this problem on Intel i7-8550U
>>
>> I haven't started debugging yet. I will have to go back and
>> check if it is introduced in 5.6.4-rc1. 5.6-3-rc2 is the last
>> good one.
>>
>> I will update you later on today with bisect data.
> 
> Oh nice, we are bug-compatible with mainline :(
> 

Okay success. I reverted it and Linux 5.6-rc1 no longer hangs
on reboot/poweroff

git bisect bad
a655a99c9f6a1d819d695fca6d48b450449f45ee is the first bad commit

Okay success. I reverted it and Linux 5.6-rc1 no longer hangs
on reboot/poweroff

I am building Linux 5.7-rc1 with this reverted now.

Details and full bisect log. I am building Linux 5.7-rc1 with
this reverted now.

commit a655a99c9f6a1d819d695fca6d48b450449f45ee
Author: Prike Liang <Prike.Liang@....com>
Date:   Tue Apr 7 20:21:26 2020 +0800

     drm/amdgpu: fix gfx hang during suspend with video playback (v2)

     [ Upstream commit 487eca11a321ef33bcf4ca5adb3c0c4954db1b58 ]

     The system will be hang up during S3 suspend because of SMU is pending
     for GC not respose the register CP_HQD_ACTIVE access request.This issue
     root cause of accessing the GC register under enter GFX CGGPG and can
     be fixed by disable GFX CGPG before perform suspend.

     v2: Use disable the GFX CGPG instead of RLC safe mode guard.

     Signed-off-by: Prike Liang <Prike.Liang@....com>
     Tested-by: Mengbing Wang <Mengbing.Wang@....com>
     Reviewed-by: Huang Rui <ray.huang@....com>
     Signed-off-by: Alex Deucher <alexander.deucher@....com>
     Cc: stable@...r.kernel.org
     Signed-off-by: Sasha Levin <sashal@...nel.org>

:040000 040000 95fb17ff249bfc19d8b65119fdcb5a4ced21d487 
7a62a4762daedbb41f0eda5831a116ad2c2b8077 M      drivers

Full bisect log:
git bisect start
# good: [0a27a29496060843ae3a8fe78aaec0062cbd5dfa] Linux 5.6.4
git bisect good 0a27a29496060843ae3a8fe78aaec0062cbd5dfa
# bad: [576aa353744ce5f1279071363e4a55e97f486f39] Linux 5.6.5-rc1
git bisect bad 576aa353744ce5f1279071363e4a55e97f486f39
# good: [7509db5d111a5763a199902052eecc480e0ec724] x86/tsc_msr: Make MSR 
derived TSC frequency more accurate
git bisect good 7509db5d111a5763a199902052eecc480e0ec724
# good: [15f1ead7d7966d087352ba2cf81a1759b25ad163] scsi: lpfc: Fix 
broken Credit Recovery after driver load
git bisect good 15f1ead7d7966d087352ba2cf81a1759b25ad163
# good: [9e52b4ab5fadd803c8c2e617aa8c151720757fb1] s390/diag: fix 
display of diagnose call statistics
git bisect good 9e52b4ab5fadd803c8c2e617aa8c151720757fb1
# good: [3e1e6903924fd6c95db7e46c5baa41dfa0f46fdb] 
powerpc/hash64/devmap: Use H_PAGE_THP_HUGE when setting up huge devmap 
PTE entries
git bisect good 3e1e6903924fd6c95db7e46c5baa41dfa0f46fdb
# good: [0344e0fee2f904ebce1d58bec8ace3ee9cf5f777] drm/dp_mst: Fix 
clearing payload state on topology disable
git bisect good 0344e0fee2f904ebce1d58bec8ace3ee9cf5f777
# bad: [136881c0420bb52d5f21f75688f5aee1cf401737] perf/core: Unify 
{pinned,flexible}_sched_in()
git bisect bad 136881c0420bb52d5f21f75688f5aee1cf401737
# bad: [0d928b424b99cfe0e7806c530f6039a053d5082d] drm/i915/ggtt: do not 
set bits 1-11 in gen12 ptes
git bisect bad 0d928b424b99cfe0e7806c530f6039a053d5082d
# bad: [a655a99c9f6a1d819d695fca6d48b450449f45ee] drm/amdgpu: fix gfx 
hang during suspend with video playback (v2)
git bisect bad a655a99c9f6a1d819d695fca6d48b450449f45ee
# first bad commit: [a655a99c9f6a1d819d695fca6d48b450449f45ee] 
drm/amdgpu: fix gfx hang during suspend with video playback (v2)

thanks,
-- Shuah