linux-kernel - Re: [RFC net-next PATCH v2 1/2] net/fsl: add ACPI support for mdio bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 Apr 2020 14:50:01 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     Calvin Johnson <calvin.johnson@....nxp.com>, linux.cj@...il.com,
        Jeremy Linton <jeremy.linton@....com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Cristi Sovaiala <cristian.sovaiala@....com>,
        Florin Laurentiu Chiculita <florinlaurentiu.chiculita@....com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Madalin Bucur <madalin.bucur@....nxp.com>,
        netdev <netdev@...r.kernel.org>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        Diana Madalina Craciun <diana.craciun@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Varun Sethi <V.Sethi@....com>, Marcin Wojtas <mw@...ihalf.com>,
        "Rajesh V . Bikkina" <rajesh.bikkina@....com>,
        Pankaj Bansal <pankaj.bansal@....com>,
        Makarand Pawagi <makarand.pawagi@....com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [RFC net-next PATCH v2 1/2] net/fsl: add ACPI support for mdio bus

On Sat, Apr 18, 2020 at 2:41 PM Russell King - ARM Linux admin
<linux@...linux.org.uk> wrote:
> On Sat, Apr 18, 2020 at 04:24:31PM +0530, Calvin Johnson wrote:

> You seem to be duplicating the OF implementation in a private driver,
> converting it to fwnode.  This is not how we develop the Linux kernel.
> We fix subsystem problems by fixing the subsystems, not by throwing
> what should be subsystem code into private drivers.

I didn't dive into the details, but I feel same way.

-- 
With Best Regards,
Andy Shevchenko