linux-kernel - RE: [PATCH] media: v4l2-compat-ioctl32.c: copy reserved2 field in get_v4l2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <145301d6152f$6d5b6240$481226c0$@samsung.com>
Date:   Sat, 18 Apr 2020 12:14:09 +0900
From:   "Sunyoung Kang" <sy0816.kang@...sung.com>
To:     "'Greg Kroah-Hartman'" <gregkh@...uxfoundation.org>
Cc:     <mchehab@...nel.org>, "'Hans Verkuil'" <hverkuil-cisco@...all.nl>,
        "'Arnd Bergmann'" <arnd@...db.de>,
        "'Thomas Gleixner'" <tglx@...utronix.de>,
        <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] media: v4l2-compat-ioctl32.c: copy reserved2 field in
 get_v4l2_buffer32

Exynos video codec driver uses reserved2 value. How will reserved2 be used
for future use?

Thanks
Sunyoung

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Sent: Friday, April 17, 2020 5:35 PM
> To: sy0816.kang@...sung.com
> Cc: mchehab@...nel.org; Hans Verkuil <hverkuil-cisco@...all.nl>; Arnd
> Bergmann <arnd@...db.de>; Thomas Gleixner <tglx@...utronix.de>; linux-
> media@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] media: v4l2-compat-ioctl32.c: copy reserved2 field in
> get_v4l2_buffer32
> 
> On Fri, Apr 17, 2020 at 11:45:23AM +0900, sy0816.kang@...sung.com wrote:
> > From: Sunyoung Kang <sy0816.kang@...sung.com>
> >
> > get_v4l2_buffer32() didn't copy reserved2 field from userspace to
driver.
> > So the reserved2 value is not received through compat-ioctl32 in driver.
> > This patch copy reserved2 field of v4l2_buffer in get_v4l2_buffer32().
> >
> > Signed-off-by: Sunyoung Kang <sy0816.kang@...sung.com>
> > ---
> >  drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> What driver is using the reserved fields?  They should be ignored as they
> are "reserved" for future use.
> 
> thanks,
> 
> greg k-h