linux-kernel - Re: [PATCH] vfs: add faccessat2 syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c47459a5-3323-121e-ec66-4a8eb2a8afca@samba.org>
Date:   Sat, 18 Apr 2020 20:36:10 +0200
From:   Stefan Metzmacher <metze@...ba.org>
To:     Miklos Szeredi <mszeredi@...hat.com>,
        Al Viro <viro@...IV.linux.org.uk>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-api@...r.kernel.org, Eric Sandeen <sandeen@...deen.net>
Subject: Re: [PATCH] vfs: add faccessat2 syscall

Hi Miklos,

> POSIX defines faccessat() as having a fourth "flags" argument, while the
> linux syscall doesn't have it.  Glibc tries to emulate AT_EACCESS and
> AT_SYMLINK_NOFOLLOW, but AT_EACCESS emulation is broken.
> 
> Add a new faccessat(2) syscall with the added flags argument and implement
> both flags.
> 
> The value of AT_EACCESS is defined in glibc headers to be the same as
> AT_REMOVEDIR.  Use this value for the kernel interface as well, together
> with the explanatory comment.

It would be nice if resolv_flags would also be passed in addition to the
at flags.
See:https://lore.kernel.org/linux-api/CAHk-=wiaL6zznNtCHKg6+MJuCqDxO=yVfms3qR9A0czjKuSSiA@mail.gmail.com/

We should avoid expecting yet another syscall in near future.

metze



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)