[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b88d6f8b-e6af-7071-cefa-dc12e79116b6@infradead.org>
Date: Sat, 18 Apr 2020 11:53:05 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Matthew Wilcox <willy@...radead.org>
Cc: linux-kernel@...r.kernel.org,
Linus Torvalds <torvalds@...ux-foundation.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Alexander Viro <viro@...iv.linux.org.uk>,
linux-fsdevel@...r.kernel.org,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
linux-input@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-usb@...r.kernel.org,
"J. Bruce Fields" <bfields@...ldses.org>,
Chuck Lever <chuck.lever@...cle.com>,
linux-nfs@...r.kernel.org,
Johannes Berg <johannes@...solutions.net>,
Dan Williams <dan.j.williams@...el.com>,
Vishal Verma <vishal.l.verma@...el.com>,
Dave Jiang <dave.jiang@...el.com>, linux-nvdimm@...ts.01.org,
"Martin K. Petersen" <martin.petersen@...cle.com>,
linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
Zzy Wysm <zzy@...wysm.com>
Subject: Re: [PATCH 7/9] drivers/base: fix empty-body warnings in
devcoredump.c
On 4/18/20 11:50 AM, Matthew Wilcox wrote:
> On Sat, Apr 18, 2020 at 11:41:09AM -0700, Randy Dunlap wrote:
>> @@ -294,11 +295,11 @@ void dev_coredumpm(struct device *dev, s
>>
>> if (sysfs_create_link(&devcd->devcd_dev.kobj, &dev->kobj,
>> "failing_device"))
>> - /* nothing - symlink will be missing */;
>> + do_empty(); /* nothing - symlink will be missing */
>>
>> if (sysfs_create_link(&dev->kobj, &devcd->devcd_dev.kobj,
>> "devcoredump"))
>> - /* nothing - symlink will be missing */;
>> + do_empty(); /* nothing - symlink will be missing */
>>
>> INIT_DELAYED_WORK(&devcd->del_wk, devcd_del);
>> schedule_delayed_work(&devcd->del_wk, DEVCD_TIMEOUT);
>
> Could just remove the 'if's?
>
> + sysfs_create_link(&devcd->devcd_dev.kobj, &dev->kobj,
> + "failing_device");
>
OK.
thanks.
--
~Randy
Powered by blists - more mailing lists