linux-kernel - Re: [PATCH] tipc: Fix potential tipc_node refcnt leak in tipc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 18 Apr 2020 13:26:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyuyang19@...an.edu.cn
Cc:     jmaloy@...hat.com, ying.xue@...driver.com, kuba@...nel.org,
        netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, yuanxzhang@...an.edu.cn,
        kjlu@....edu, tanxin.ctf@...il.com
Subject: Re: [PATCH] tipc: Fix potential tipc_node refcnt leak in tipc_rcv

From: Xiyu Yang <xiyuyang19@...an.edu.cn>
Date: Wed, 15 Apr 2020 16:40:28 +0800

> tipc_rcv() invokes tipc_node_find() twice, which returns a reference of
> the specified tipc_node object to "n" with increased refcnt.
> 
> When tipc_rcv() returns or a new object is assigned to "n", the original
> local reference of "n" becomes invalid, so the refcount should be
> decreased to keep refcount balanced.
> 
> The issue happens in some paths of tipc_rcv(), which forget to decrease
> the refcnt increased by tipc_node_find() and will cause a refcnt leak.
> 
> Fix this issue by calling tipc_node_put() before the original object
> pointed by "n" becomes invalid.
> 
> Signed-off-by: Xiyu Yang <xiyuyang19@...an.edu.cn>
> Signed-off-by: Xin Tan <tanxin.ctf@...il.com>

Applied and queued up for -stable.