linux-kernel - Re: [PATCH] drm/amdgpu: Remove an unnecessary null pointer check in amdgpu_cs_bo_handles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1d0f1eb5-a26f-1739-9222-a39c92ba3024@web.de>
Date:   Sun, 19 Apr 2020 10:15:35 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Bernard Zhao <bernard@...o.com>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        Chunming Zhou <David1.Zhou@....com>,
        Felix Kühling <Felix.Kuehling@....com>,
        Nicolai Hähnle <nicolai.haehnle@....com>,
        Nirmoy Das <nirmoy.das@....com>,
        Philip Yang <Philip.Yang@....com>
Cc:     Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...ux.ie>,
        linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH] drm/amdgpu: Remove an unnecessary null pointer check in
 amdgpu_cs_bo_handles_chunk()

> kvfree ensure that the null pointer will do nothing.

I suggest to improve the commit message.
Would you like to adjust the patch subject?

Are you looking for further questionable condition checks?


…
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -98,8 +98,7 @@ static int amdgpu_cs_bo_handles_chunk(struct amdgpu_cs_parser *p,
…
> +	kvfree(info);
>
>  	return r;
>  }

How do you think about to omit a blank line behind the function call
at this source code place?

Regards,
Markus