linux-kernel - [PATCH] mfd: asic3: Delete superfluous error message in asic3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 19 Apr 2020 17:18:55 +0800
From:   Tang Bin <tangbin@...s.chinamobile.com>
To:     lee.jones@...aro.org
Cc:     linux-kernel@...r.kernel.org,
        Tang Bin <tangbin@...s.chinamobile.com>,
        Shengju Zhang <zhangshengju@...s.chinamobile.com>
Subject: [PATCH] mfd: asic3: Delete superfluous error message in asic3_probe()

In the function asic3_probe(), when get irq failed, the function
asic3_irq_probe() can called platform_get_irq(), which logs an
error message, so remove redundant message here.

Signed-off-by: Shengju Zhang <zhangshengju@...s.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
---
 drivers/mfd/asic3.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
index a6bd2134c..7694de3f1 100644
--- a/drivers/mfd/asic3.c
+++ b/drivers/mfd/asic3.c
@@ -987,10 +987,8 @@ static int __init asic3_probe(struct platform_device *pdev)
 	asic3_write_register(asic, ASIC3_OFFSET(CLOCK, SEL), clksel);
 
 	ret = asic3_irq_probe(pdev);
-	if (ret < 0) {
-		dev_err(asic->dev, "Couldn't probe IRQs\n");
+	if (ret < 0)
 		goto out_unmap;
-	}
 
 	asic->gpio.label = "asic3";
 	asic->gpio.base = pdata->gpio_base;
-- 
2.20.1.windows.1