linux-kernel - Re: mmotm 2020-04-17-20-35 uploaded (squashfs)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200419105633.GX5820@bombadil.infradead.org>
Date:   Sun, 19 Apr 2020 03:56:33 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Randy Dunlap <rdunlap@...radead.org>, broonie@...nel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, linux-next@...r.kernel.org, mhocko@...e.cz,
        mm-commits@...r.kernel.org, sfr@...b.auug.org.au,
        Phillip Lougher <phillip@...ashfs.org.uk>,
        squashfs-devel@...ts.sourceforge.net,
        Philippe Liard <pliard@...gle.com>
Subject: Re: mmotm 2020-04-17-20-35 uploaded (squashfs)

On Sat, Apr 18, 2020 at 12:47:28PM -0700, Andrew Morton wrote:
> On Sat, 18 Apr 2020 08:56:31 -0700 Randy Dunlap <rdunlap@...radead.org> wrote:
> 
> > On 4/17/20 8:36 PM, akpm@...ux-foundation.org wrote:
> > > The mm-of-the-moment snapshot 2020-04-17-20-35 has been uploaded to
> > > 
> > >    http://www.ozlabs.org/~akpm/mmotm/
> > > 
> > > mmotm-readme.txt says
> > > 
> > > README for mm-of-the-moment:
> > > 
> > > http://www.ozlabs.org/~akpm/mmotm/
> > > 
> > > This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> > > more than once a week.
> > > 
> > > You will need quilt to apply these patches to the latest Linus release (5.x
> > > or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
> > > http://ozlabs.org/~akpm/mmotm/series
> > > 
> > > The file broken-out.tar.gz contains two datestamp files: .DATE and
> > > .DATE-yyyy-mm-dd-hh-mm-ss.  Both contain the string yyyy-mm-dd-hh-mm-ss,
> > > followed by the base kernel version against which this patch series is to
> > > be applied.
> > 
> > on x86_64:
> > 
> >   CC      fs/squashfs/decompressor_multi_percpu.o
> > ../fs/squashfs/decompressor_multi_percpu.c:75:5: error: conflicting types for ‘squashfs_decompress’
> >  int squashfs_decompress(struct squashfs_sb_info *msblk, struct buffer_head **bh,
> >      ^~~~~~~~~~~~~~~~~~~
> 
> Thanks.  Seems that file was missed.
> 
> Also, this code jumps through horrifying hoops in order to initialize
> locals at their definition site.  But the code looks so much better if
> we Just Don't Do That!

I think the code would look even better if things just Had The Right Type!

struct squashfs_sb_info {
...
-       struct squashfs_stream                  *stream;
+	union {
+		struct squashfs_stream		*stream;
+		struct squashfs_stream __percpu	*percpu_stream;
+	};

int squashfs_decompress(struct squashfs_sb_info *msblk, struct bio *bio,
		int offset, int length, struct squashfs_page_actor *output)
{
	struct squashfs_stream *stream = get_cpu_ptr(msblk->percpu_stream);
	int res = msblk->decompressor->decompress(msblk, stream->stream, bh, b,
			offset, length, output);
	...

As an aside, that calling convention could do with putting some of the
arguments into a struct so the CPU spends less time shuffling arguments
from one register to another.