linux-kernel - Re: [PATCH] Input: xpad - Update xboxone fw2015 init packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAJmEJMxDsPmOpYHYYzUXYxknFe6Uwo6OuF+=Q3bzUmqxK3Psag@mail.gmail.com>
Date:   Sun, 19 Apr 2020 20:22:48 +0200
From:   LuK1337 <priv.luk@...il.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     LuK1337 <priv.luk@...il.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Allison Randal <allison@...utok.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Richard Fontana <rfontana@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: xpad - Update xboxone fw2015 init packet

I had this issue with official Microsoft Xbox One S Controler (model: 1708);
It might also be firmware version related as I recently updated my firmware
to the latest one but I'm not sure about that.

(also sorry for duplicate msgs that you might have received from me;
I'm new to lkml)
On Sun, Apr 19, 2020 at 8:14 PM LuK1337 <priv.luk@...il.com> wrote:
>
> I had this issue with official Microsoft Xbox One S Controler (model: 1708);
> It might also be firmware version related as I recently updated my firmware
> to the latest one but I'm not sure about that.
>
> On Sun, Apr 19, 2020 at 8:01 PM Dmitry Torokhov <dmitry.torokhov@...il.com> wrote:
>>
>> On Sun, Apr 19, 2020 at 09:46:23AM +0200, LuK1337 wrote:
>> > From: Łukasz Patron <priv.luk@...il.com>
>> >
>> > Appending { 0x05, 0x20, 0x02, 0x0f, 0x06 } to
>> > xboxone_fw2015_init fixes an issue where the
>> > controller is somewhat stuck in bluetooth
>> > mode until you plug it into Windows PC.
>> >
>> > Signed-off-by: Łukasz Patron <priv.luk@...il.com>
>>
>> Thank you Łukasz. Could you please tell me what device(s) have you
>> observed the issue with? I am a bit worried if this may interfere with
>> other devices that currently work fine with the driver. Cameron, Mark,
>> do you have any concerns here?
>>
>> > ---
>> >  drivers/input/joystick/xpad.c | 3 ++-
>> >  1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
>> > index 6b40a1c68f9f..894fa81f717a 100644
>> > --- a/drivers/input/joystick/xpad.c
>> > +++ b/drivers/input/joystick/xpad.c
>> > @@ -455,7 +455,8 @@ struct xboxone_init_packet {
>> >   * or later firmware installed (or present from the factory).
>> >   */
>> >  static const u8 xboxone_fw2015_init[] = {
>> > -     0x05, 0x20, 0x00, 0x01, 0x00
>> > +     0x05, 0x20, 0x00, 0x01, 0x00,
>> > +     0x05, 0x20, 0x02, 0x0f, 0x06
>> >  };
>> >
>> >  /*
>> > --
>> > 2.26.0
>> >
>>
>> Thanks.
>>
>> --
>> Dmitry