linux-kernel - Re: [RFC][PATCH 3/7] objtool: Allow branches within the same alternative.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200419192754.GY20696@hirez.programming.kicks-ass.net>
Date:   Sun, 19 Apr 2020 21:27:54 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     alexandre.chartre@...cle.com, linux-kernel@...r.kernel.org,
        jthierry@...hat.com, tglx@...utronix.de, x86@...nel.org
Subject: Re: [RFC][PATCH 3/7] objtool: Allow branches within the same
 alternative.

On Sun, Apr 19, 2020 at 11:32:19AM -0500, Josh Poimboeuf wrote:
> On Thu, Apr 16, 2020 at 05:07:55PM +0200, Peter Zijlstra wrote:
> > From: Alexandre Chartre <alexandre.chartre@...cle.com>
> > 
> > Currently objtool prevents any branch to an alternative. While preventing
> > branching from the outside to the middle of an alternative makes perfect
> > sense, branching within the same alternative should be allowed. To do so,
> > identify each alternative and check that a branch to an alternative comes
> > from the same alternative.
> > 
> > Signed-off-by: Alexandre Chartre <alexandre.chartre@...cle.com>
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> > Link: https://lkml.kernel.org/r/20200414103618.12657-3-alexandre.chartre@oracle.com
> 
> I I think I'd rather just drop this patch.  It adds some complexity and
> I don't really see a benefit to having the warning in the first place.

Also; we totally don't need it, sorry for not realizing that earlier.
Consider it gone.