linux-kernel - Re: [PATCH RESEND] kernel/smp: Use smp_call_func_t in on_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAWJmAZ3p9jdSUi5H0+kmCN7h-rzBA0=9tR-y5J4kJgYDUDBdQ@mail.gmail.com>
Date:   Sun, 19 Apr 2020 11:21:59 +0800
From:   Tao pilgrim <pilgrimtao@...il.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     tglx@...utronix.de, peterz@...radead.org, namit@...are.com,
        linux-kernel@...r.kernel.org, songmuchun@...edance.com
Subject: Re: [PATCH RESEND] kernel/smp: Use smp_call_func_t in on_each_cpu()

On Sat, Apr 18, 2020 at 1:05 AM Sebastian Andrzej Siewior
<bigeasy@...utronix.de> wrote:
>
> On 2020-04-18 00:24:51 [+0800], Kaitao Cheng wrote:
> > There is already a typedef smp_call_func_t, so we can just use it,
> > maybe better.
> >
> > Fixes: 3a5f65df5a0fc ("Typedef SMP call function pointer")
> > Signed-off-by: Kaitao Cheng <pilgrimtao@...il.com>
>
> I would not go as far as the Fixes: tag but otherwise:
>
>   Acked-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Thanks for your review. Do you mean I should delete the Fixes tag?

>
> > ---
> >  kernel/smp.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/smp.c b/kernel/smp.c
> > index 786092aabdcd..84303197caf9 100644
> > --- a/kernel/smp.c
> > +++ b/kernel/smp.c
> > @@ -620,7 +620,7 @@ void __init smp_init(void)
> >   * early_boot_irqs_disabled is set.  Use local_irq_save/restore() instead
> >   * of local_irq_disable/enable().
> >   */
> > -void on_each_cpu(void (*func) (void *info), void *info, int wait)
> > +void on_each_cpu(smp_call_func_t func, void *info, int wait)
> >  {
> >       unsigned long flags;
> >
>
> Sebastian