[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <54b63fd9-0c73-5fdc-b43d-6ab4aec3a00d@acm.org>
Date: Sun, 19 Apr 2020 15:50:13 -0700
From: Bart Van Assche <bvanassche@....org>
To: Luis Chamberlain <mcgrof@...nel.org>, axboe@...nel.dk,
viro@...iv.linux.org.uk, gregkh@...uxfoundation.org,
rostedt@...dmis.org, mingo@...hat.com, jack@...e.cz,
ming.lei@...hat.com, nstange@...e.de, akpm@...ux-foundation.org
Cc: mhocko@...e.com, yukuai3@...wei.com, linux-block@...r.kernel.org,
linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 05/10] blktrace: upgrade warns to BUG_ON() on
unexpected circmunstances
On 4/19/20 12:45 PM, Luis Chamberlain wrote:
> @@ -498,10 +498,7 @@ static struct dentry *blk_trace_debugfs_dir(struct blk_user_trace_setup *buts,
> struct dentry *dir = NULL;
>
> /* This can only happen if we have a bug on our lower layers */
> - if (!q->kobj.parent) {
> - pr_warn("%s: request_queue parent is gone\n", buts->name);
> - return NULL;
> - }
> + BUG_ON(!q->kobj.parent);
Does the following quote from Linus also apply to this patch: "there is
NO F*CKING EXCUSE to knowingly kill the kernel." See also
https://lkml.org/lkml/2016/10/4/1.
Thanks,
Bart.
Powered by blists - more mailing lists