linux-kernel - Re: [PATCH 0/2] ASoC: rsnd: multi-SSI setup fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pnc3t5b2.wl-kuninori.morimoto.gx@renesas.com>
Date:   20 Apr 2020 08:38:09 +0900
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Matthias Blankertz <matthias.blankertz@...itec.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH 0/2] ASoC: rsnd: multi-SSI setup fixes


Hi Matthias

> Fix rsnd_dai_call() operations being performed twice for the master SSI
> in multi-SSI setups, and fix the rsnd_ssi_stop operation for multi-SSI
> setups.
> The only visible effect of these issues was some "status check failed"
> spam when the rsnd_ssi_stop was called, but overall the code is cleaner
> now, and some questionable writes to the SSICR register which did not
> lead to any observable misbehaviour but were contrary to the datasheet
> are fixed.
> 
> Mark:
> The first patch kind of reverts my "ASoC: rsnd: Fix parent SSI
> start/stop in multi-SSI mode" from a few days ago and achieves the same
> effect in a simpler fashion, if you would prefer a clean patch series
> based on v5.6 drop me a note.

Nice catch !
For all patches

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

Thank you for your help !!

Best regards
---
Kuninori Morimoto