linux-kernel - Re: [PATCH 2/2][next] m68k: amiga: config: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50f85dd2-8250-1ca8-e2dd-4bba93a62736@embeddedor.com>
Date:   Mon, 20 Apr 2020 11:07:31 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2][next] m68k: amiga: config: Mark expected switch
 fall-through



On 4/20/20 02:17, Geert Uytterhoeven wrote:
> On Fri, Mar 27, 2020 at 12:25 AM Gustavo A. R. Silva
> <gustavo@...eddedor.com> wrote:
>> Mark switch cases where we are expecting to fall through.
>>
>> This patch fixes the following warning (Building: allmodconfig m68k):
>>
>> arch/m68k/amiga/config.c: In function ‘amiga_identify’:
>> ./arch/m68k/include/asm/amigahw.h:42:50: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>  #define AMIGAHW_SET(name) (amiga_hw_present.name = 1)
>>                            ~~~~~~~~~~~~~~~~~~~~~~~^~~~
>> arch/m68k/amiga/config.c:223:3: note: in expansion of macro ‘AMIGAHW_SET’
>>    AMIGAHW_SET(PCMCIA);
>>    ^~~~~~~~~~~
>> arch/m68k/amiga/config.c:224:2: note: here
>>   case AMI_500:
>>   ^~~~
>>
>> Replace the existing /* fall through */ comments and fix the issue above
>> by using the new pseudo-keyword fallthrough;
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> i.e. will queue in the m68k for-v5.8 branch.
> 

Geert,

I wonder if you received the first patch of the series.

It seems lkml has been eating some messages, recently.

Thanks
--
Gustavo