linux-kernel - Re: [PATCH] PCI: pciehp: remove unused EMI() macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200420175734.GA53587@google.com>
Date:   Mon, 20 Apr 2020 12:57:34 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Ani Sinha <ani@...sinha.ca>
Cc:     linux-kernel@...r.kernel.org, ani@...rban.org,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Keith Busch <keith.busch@...el.com>,
        Frederick Lawler <fred@...dlawl.com>,
        Denis Efremov <efremov@...ux.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Lukas Wunner <lukas@...ner.de>, linux-pci@...r.kernel.org
Subject: Re: [PATCH] PCI: pciehp: remove unused EMI() macro

Hi Ani,

On Mon, Apr 20, 2020 at 06:21:41PM +0530, Ani Sinha wrote:
> EMI() macro seems to be unused. So removing it. Thanks
> Mika Westerberg <mika.westerberg@...ux.intel.com> for
> pointing it out.
> 
> Signed-off-by: Ani Sinha <ani@...sinha.ca>
> ---
>  drivers/pci/hotplug/pciehp.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
> index 5747967..4fd200d 100644
> --- a/drivers/pci/hotplug/pciehp.h
> +++ b/drivers/pci/hotplug/pciehp.h
> @@ -148,7 +148,6 @@ struct controller {
>  #define MRL_SENS(ctrl)		((ctrl)->slot_cap & PCI_EXP_SLTCAP_MRLSP)
>  #define ATTN_LED(ctrl)		((ctrl)->slot_cap & PCI_EXP_SLTCAP_AIP)
>  #define PWR_LED(ctrl)		((ctrl)->slot_cap & PCI_EXP_SLTCAP_PIP)
> -#define EMI(ctrl)		((ctrl)->slot_cap & PCI_EXP_SLTCAP_EIP)

Thanks for the patch!  Can you squash it together with the HP_SUPR_RM
removal (and also check for any other unused ones at the same time)?
For trivial things like this, I'd rather merge one patch that removes
several unused things at once instead of several patches.

I like the subject of this one ("Removed unused ..."), but please
capitalize it as you did for the HP_SUPR_RM one so it matches previous
history.

Bjorn

>  #define NO_CMD_CMPL(ctrl)	((ctrl)->slot_cap & PCI_EXP_SLTCAP_NCCS)
>  #define PSN(ctrl)		(((ctrl)->slot_cap & PCI_EXP_SLTCAP_PSN) >> 19)
>  
> -- 
> 2.7.4
>