linux-kernel - Re: [RFC] seq_buf: Export symbols to external modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200420152043.1cd0a2ae@gandalf.local.home>
Date:   Mon, 20 Apr 2020 15:20:43 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Vaibhav Jain <vaibhav@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org,
        "Aneesh Kumar K . V" <aneesh.kumar@...ux.ibm.com>,
        Michael Ellerman <ellerman@....ibm.com>,
        Piotr Maziarz <piotrx.maziarz@...ux.intel.com>,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        Borislav Petkov <bp@...en8.de>
Subject: Re: [RFC] seq_buf: Export symbols to external modules

On Fri, 17 Apr 2020 14:47:48 +0530
Vaibhav Jain <vaibhav@...ux.ibm.com> wrote:

> Having these symbols exported to modules should simplify generating file
> content for pseudo file systems like sysfs or procfs. Many of the in
> kernel modules export atleast one such attribute file. Using seq_buf
> api provides a safe way to populate the read buffers for these attrs
> as these string buffers are PAGE_SIZE in length and a buggy module can
> easily cause an overflow.
> 
> My specific use-case is exporting a set of nvdimm specific flags from
> papr_scm kernel module [1] via sysfs through a patch proposed at [2] and
> using seq_buf should considerably simply my code as suggested by Mpe
> at [3].
> 
> [1] arch/powerpc/platforms/pseries/papr_scm.c
> [2] https://lore.kernel.org/linux-nvdimm/20200331143229.306718-2-vaibhav@linux.ibm.com
> [3] https://lore.kernel.org/linux-nvdimm/878sjetcis.fsf@mpe.ellerman.id.au

This patch should be added to a patch series that needs it. Then I'll give
my ack to it. That way, there's a reason to export them.

-- Steve