linux-kernel - Re: [PATCH 01/15] sched: make nr_running() return "unsigned int"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Apr 2020 14:05:57 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, pmladek@...e.com,
        rostedt@...dmis.org, sergey.senozhatsky@...il.com,
        andriy.shevchenko@...ux.intel.com, linux@...musvillemoes.dk
Subject: Re: [PATCH 01/15] sched: make nr_running() return "unsigned int"

On Mon, Apr 20, 2020 at 11:57:29PM +0300, Alexey Dobriyan wrote:
> I don't anyone have been crazy enough to spawn 2^32 threads.
> It'd require absurd amounts of physical memory,  and bump into futex pid
> limit anyway.
> 
> Meanwhile save few bits on REX prefixes and some stack space for upcoming
> print_integer() stuff.
> 
> And remove "extern" from prototypes while I'm at it.

It seems like there's a few more places to fix in this regard?

kernel/sched/fair.c:static u64 __sched_period(unsigned long nr_running)
kernel/sched/sched.h:   unsigned long           dl_nr_running;
kernel/sched/core.c:unsigned long nr_iowait_cpu(int cpu)
kernel/sched/core.c:unsigned long nr_iowait(void)
kernel/sched/loadavg.c: long nr_active, delta = 0;
kernel/sched/sched.h:   unsigned long           rt_nr_migratory;
kernel/sched/sched.h:   unsigned long           rt_nr_total;
kernel/sched/sched.h:   unsigned long           rt_nr_boosted;
kernel/sched/sched.h:   unsigned long           dl_nr_running;
kernel/sched/sched.h:   unsigned long           dl_nr_migratory;
kernel/sched/sched.h:   unsigned long           nr_uninterruptible;