linux-kernel - Re: linux-next: Tree for Apr 20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200420172559.7b6dc5f1@canb.auug.org.au>
Date:   Mon, 20 Apr 2020 17:25:59 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Christian Borntraeger <borntraeger@...ibm.com>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        linux-s390 <linux-s390@...r.kernel.org>,
        Hadar Gat <hadar.gat@....com>
Subject: Re: linux-next: Tree for Apr 20

Hi all,

On Mon, 20 Apr 2020 09:14:15 +0200 Christian Borntraeger <borntraeger@...ibm.com> wrote:
>
> s390 defconfig still does not compile. While the media kconfig problem is gone I now have
> 
>   CC [M]  drivers/char/hw_random/cctrng.o
> drivers/char/hw_random/cctrng.c: In function ‘cc_trng_compwork_handler’:
> drivers/char/hw_random/cctrng.c:334:49: error: ‘fips_enabled’ undeclared (first use in this function); did you mean ‘vdso_enabled’?
>   334 |  if (CC_REG_FLD_GET(RNG_ISR, CRNGT_ERR, isr) && fips_enabled) {
>       |                                                 ^~~~~~~~~~~~
>       |                                                 vdso_enabled
> drivers/char/hw_random/cctrng.c:334:49: note: each undeclared identifier is reported only once for each function it appears in
> drivers/char/hw_random/cctrng.c:335:3: error: implicit declaration of function ‘fips_fail_notify’ [-Werror=implicit-function-declaration]
>   335 |   fips_fail_notify();
>       |   ^~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> 
> Can we maybe make this driver depend on ARM?

Caused by commit

  a583ed310bb6 ("hwrng: cctrng - introduce Arm CryptoCell driver")

which has neglected to include linux/fips.h ...

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped