linux-kernel - Re: [tip: ras/core] x86/mce: Add a struct mce.kflags field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200420080640.GB32592@infradead.org>
Date:   Mon, 20 Apr 2020 01:06:40 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     linux-tip-commits@...r.kernel.org, Tony Luck <tony.luck@...el.com>,
        Borislav Petkov <bp@...e.de>, x86 <x86@...nel.org>
Subject: Re: [tip: ras/core] x86/mce: Add a struct mce.kflags field

On Wed, Apr 15, 2020 at 09:49:48AM -0000, tip-bot2 for Tony Luck wrote:
> The following commit has been merged into the ras/core branch of tip:
> 
> Commit-ID:     1de08dccd383482a3e88845d3554094d338f5ff9
> Gitweb:        https://git.kernel.org/tip/1de08dccd383482a3e88845d3554094d338f5ff9
> Author:        Tony Luck <tony.luck@...el.com>
> AuthorDate:    Fri, 14 Feb 2020 14:27:16 -08:00
> Committer:     Borislav Petkov <bp@...e.de>
> CommitterDate: Tue, 14 Apr 2020 15:58:43 +02:00
> 
> x86/mce: Add a struct mce.kflags field
> 
> There can be many different subsystems register on the mce handler
> chain. Add a new bitmask field and define values so that handlers can
> indicate whether they took any action to log or otherwise handle an
> error.
> 
> The default handler at the end of the chain can use this information to
> decide whether to print to the console log.
> 
> Boris suggested a generic name and leaving plenty of spare bits for
> possible future use.
> 
>  [ bp: Move flag bits to the internal mce.h header and use BIT_ULL(). ]

Err, how can you add a new field to an uapi structure and not break
things?